BGDIINF_SB-2820 : legacy parameters double encoded#391
Merged
Conversation
Contributor
|
Legacy url with |
ltshb
approved these changes
Mar 14, 2023
Contributor
ltshb
left a comment
There was a problem hiding this comment.
👍🏼
After testing on the old viewer, the + sign was not decoded in a space there so it is ok to have it in the search while translating legacy urls.
Issue : Upon receiving legacy parameters, the application would encode them on reception (which is an expected behavior), then create a new query with those adapted parameters, which would encode them again (For example, a space would become `%20`, then `%2520`). Fix : We decode the URI parameters before storing them in the new query Parameters, ensuring they won't be encoded twice.
fd4e1e7 to
2f3d38a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : Upon receiving legacy parameters, the application would encode them on reception (which is an expected behavior), then create a new query with those adapted parameters, which would encode them again (For example, a space would become
%20, then%2520).Fix : We decode the URI parameters before storing them in the new query Parameters, ensuring they won't be encoded twice.
Test link