Skip to content

BGDIINF_SB-2743 : aggregate TippyJS usage for third party disclaimer#389

Merged
pakb merged 2 commits intodevelopfrom
bug-BGDIINF_SB-2743_third_party_tooltip_issues
Mar 7, 2023
Merged

BGDIINF_SB-2743 : aggregate TippyJS usage for third party disclaimer#389
pakb merged 2 commits intodevelopfrom
bug-BGDIINF_SB-2743_third_party_tooltip_issues

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented Mar 7, 2023

There was sometimes issue with TippyJS tooltip not showing up in the footer attributions. As it was kind of the same usage of TippyJS as the one found in the active layer menu, I aggregated the use into one single component, which encapsulate all the TippyJS logic. This should fix the discrepancy between the two use cases.

Test link with multiple external layers

Test link

@pakb pakb requested review from jedef and ltshb March 7, 2023 11:46
@github-actions github-actions bot added the bug label Mar 7, 2023
@pakb pakb marked this pull request as ready for review March 7, 2023 11:56
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

pakb added 2 commits March 7, 2023 16:05
There was sometimes issue with TippyJS tooltip not showing up in the footer attributions. As it was kind of the same usage of TippyJS as the one found in the active layer menu, I aggregated the use into one single component, which encapsulate all the TippyJS logic.
This should fix the discrepancy between the two use cases.
@pakb pakb force-pushed the bug-BGDIINF_SB-2743_third_party_tooltip_issues branch from 8734bdc to c1a3ca2 Compare March 7, 2023 15:06
@pakb pakb merged commit a330db5 into develop Mar 7, 2023
@pakb pakb deleted the bug-BGDIINF_SB-2743_third_party_tooltip_issues branch March 7, 2023 15:23
@pakb pakb mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants