Skip to content

Updating the translation JSON generation script#385

Merged
ltkum merged 1 commit intodevelopfrom
feat-BGDIINF_SB-2786-minify-translation-json
Feb 27, 2023
Merged

Updating the translation JSON generation script#385
ltkum merged 1 commit intodevelopfrom
feat-BGDIINF_SB-2786-minify-translation-json

Conversation

@ltkum
Copy link
Contributor

@ltkum ltkum commented Feb 27, 2023

Issue : Updated translations could be tedious to review, as each translation file was a one-liner JSON file.

Fix : The Script's output is now human readable. Also the script has been run to change the translation files.

Test link

Issue : Updated translations could be tedious to review, as each
translation file was a minified one-liner JSON file.

Fix : The Script's output is now human readable. Also the script has
been run to change the translation files.

Still left to do : We need to minify the translation JSON
during the production build.
@ltkum ltkum marked this pull request as ready for review February 27, 2023 12:41
@ltkum ltkum requested a review from pakb February 27, 2023 12:42
@ltkum ltkum merged commit 38861c3 into develop Feb 27, 2023
@ltkum ltkum deleted the feat-BGDIINF_SB-2786-minify-translation-json branch February 27, 2023 16:56
@pakb pakb mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants