Merged
Conversation
jedef
approved these changes
Feb 24, 2023
Contributor
jedef
left a comment
There was a problem hiding this comment.
Just a simple naming fix of a "data-cy" and its all good!
src/modules/menu/components/activeLayers/MenuActiveLayersListItem.vue
Outdated
Show resolved
Hide resolved
| <PopoverButton | ||
| v-if="hasMultipleTimestamps" | ||
| ref="popover" | ||
| popover-position="left" |
Contributor
There was a problem hiding this comment.
Why do you want the popover to open on the left? Isn't it less practical as it hides the menu when the popover is open?
Contributor
Author
There was a problem hiding this comment.
that's to fix an issue with timestamp testing in Cypress, if set to auto (left untouched) it would go on the top position, and with the dev warning, Cypress considers that it is covered by the disclaimer and fails the test of visibility. That was an "easy" fix.
We could move it to the right though...
There was a discrepancy between mf-geoadmin3 layer ordering (in the menu and URL) and web-mapviewer way of handling them. In the URL, layers should be ordered from bottom to top, and on the side menu from top to bottom (layer "on top" of the layer stack is the top layer). Topics were an issue as they list their layers to activate in the opposite order (top -> bottom) so I've inverted those layer before importing them.
instead change the e2e test to reflect the change of logic in layer ordering
8f7d43d to
f46c25b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a discrepancy between mf-geoadmin3 layer ordering (in the menu and URL) and web-mapviewer way of handling them. In the URL, layers should be ordered from bottom to top, and on the side menu from top to bottom (layer "on top" of the layer stack is the top layer). Topics were an issue as they list their layers to activate in the opposite order (top -> bottom) so I've inverted those layer before importing them.
Test link