BGDIINF_SB-2789: search results full width on phone#382
Merged
Conversation
04265e8 to
7728345
Compare
pakb
reviewed
Feb 24, 2023
7728345 to
c4f961e
Compare
pakb
approved these changes
Mar 6, 2023
Contributor
pakb
left a comment
There was a problem hiding this comment.
very minor detail so we can get rid of this !important rule
- Like with the menu, the categories of the search results now also split evenly depending solely on the max height defined for the whole search results. Scroll bars for subcategories only appear if they are needed. - Search results take normally 50% of the screen only, so that the user can preview the layers by hovering over them. However, if the screen is very small (like the landscape mode of phones), the search results take more than 50% (but max 100%) of the screen to still be usable.
When typing in the search, now the search results do not blink anymore.
c4f961e to
679e1f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link