Conversation
000034b to
ff04bb3
Compare
jedef
approved these changes
Dec 22, 2022
Contributor
jedef
left a comment
There was a problem hiding this comment.
Apart from a small typo, its all good for me. Nice work.
3d65041 to
861ca4a
Compare
Now if the loading of the KML failed in the drawing mode, we remove the kml layer as it is not selectable and we print an error message. The loading of the kml to translate it to a drawing will be automatically retried. In case of error we also display an error message at the same place as for saving error. Those errors message are also now displayed in red. Also renamed the savingStatus to drawingState which refer more to a drawing state to make the code clearer as it is also used to check if any modification on the drawing has been done. Improved the error handling and user experience in case of network failure.
861ca4a to
7b5d8df
Compare
Avoid saving new empty drawing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now if the loading of the KML failed in the drawing mode, we remove the
kml layer as it is not selectable and we print an error message. The loading
of the kml to translate it to a drawing will be automatically retried. In case
of error we also display an error message at the same place as for saving error.
Those errors message are also now displayed in red.
Also renamed the savingStatus to drawingState which refer more to a drawing state
to make the code clearer as it is also used to check if any modification on
the drawing has been done.
Improved the error handling and user experience in case of network failure.
Test link