Conversation
pakb
approved these changes
Nov 22, 2022
Contributor
pakb
left a comment
There was a problem hiding this comment.
good idea, although I'm suspecting nothing will be present in text, and the issue is somewhat related to mouse position not being interpreted correctly (we use a .click to position the mouse)
Contributor
Author
|
@pakb could not be due to a timing problem between function checkMousePositionNumberValue(expectedX, expectedY, parser) {
cy.get('[data-cy="map"]').click()
cy.get('[data-cy="mouse-position"]')
.invoke('text')
.then(parser)
.then(checkXY(expectedX, expectedY))
} |
Contributor
|
There should not be backend requests here, it should be seamless, so no alias to wait on... If we continue having issue with this test we could consider waiting for an arbitrary length of time (which is a bad practice with Cypress, but this test is way too prone to fail not to try fixing it) |
1d25449 to
9f36c71
Compare
This test did sometimes not pass without a useful info of the failure reason. Hopefully with this changes we can have a better understanding why this test is sometimes failing.
9f36c71 to
5fc02aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test did sometimes not pass without a useful info of the failure reason.
Hopefully with this changes we can have a better understanding why this test
is sometimes failing.
Test link