PB-2227: force icon width in map buttons#1572
Merged
Conversation
for unknown reasons they shrink to a width of zero when the project is bundled, but it works fine when served locally (without going through the build:prod target) So I've forced the width the same we are forcing the height of the underlying FontAwesome icon
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-2227-no-icons-in-map-buttons
|
| Run status |
|
| Run duration | 06m 37s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
261
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for unknown reasons they shrink to a width of zero when the project is bundled, but it works fine when served locally (without going through the build:prod target)
So I've forced the width the same we are forcing the height of the underlying FontAwesome icon
Test link