Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-2224-kmz-load-on-3d-viewer
|
| Run status |
|
| Run duration | 06m 52s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
261
|
| View all changes introduced in this branch ↗︎ | |
a1bbddd to
56f2da2
Compare
sommerfe
left a comment
There was a problem hiding this comment.
Code looks good, i can see KMZ files now in the 3D viewer. There might be a problem with the height of the elements being shown. Some part of the relief is being shown above the points. I can DM you the files so you can test as well.
Also is there a reason, that these KMZ files do currently not work on the 2D viewer? If they work on 3D i would also expect them to work on 2D but i can not see anything
Please do 👍
OpenLayers has a limited support for the KML spec, many tags aren't supported (hence the warning message I've added) |
As explained through DMs, we don't "clamp to ground" external KML/KMZ by default (to let people load flight path without ignoring the Z coordinate). This can be set through the layer's settings in the menu. |
providing an ArrayBuffer on the whole archive (not the underlying KML file only), so that the 3D viewer can pick it up and load the KMZ file correctly.
OpenLayers has a limited support of KML/KMZ tags (in contrast to Cesium, see CesiumGS/cesium#873 ) I've started detecting the missing ones coming through our helpdesk/user feedback and showing a warning to the user when one is found: a bit of expectation management never hurts.
56f2da2 to
6491829
Compare
|
not sure if related, but the icons on the right are not visible anymore |
It's unrelated, it's the same on every test link. Maybe has to do with a bad ServiceWorker config in this regard. |
KMZ Parsing
Pass the KMZ "content" along when parsing providing an ArrayBuffer on the whole archive (not the underlying KML file only), so that the 3D viewer can pick it up and load the KMZ file correctly.
2D Viewer
In 2D, add warning message when we detect unsupported KML tags
OpenLayers has a limited support of KML/KMZ tags (in contrast to Cesium)
I've started detecting the missing ones coming through our helpdesk/user feedback and showing a warning to the user when one is found: a bit of expectation management never hurts.
Test link