Conversation
Issue: When we want to generate a QRCode on edge or firefox (and sometimes on chrome), we are hitting the service worker cache instead, which is trying to inject the manifest. Fix: We exclude the QRCode api from the routes
…ation PB 1823: Allow QR Code to be generated again when not in cache
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 06m 31s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
254
|
| View all changes introduced in this branch ↗︎ | |
schtibe
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When introducing support for offline use of the mapviewer, we introduced a situation where QR code generation wouldn't work as soon as it was used once.
Cause: The service-worker used to cache the mapviewer for local use also cached the URL for the QR code, which was then called by the mapviewer instead of the service in the backend.
Fix: We exclude the QR Code from the caching, as we did with service print
Test link