PB-1828: Fix description always shown.#1379
Merged
ismailsunni merged 1 commit intodevelopfrom Jul 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the feature description was always shown by correctly parsing the showDescriptionOnMap property and updating the store mutation to accept the new flag.
- Parse KML string property
showDescriptionOnMapinto a boolean inkmlUtils.js - Extend
changeFeatureDescriptionmutation to optionally updateshowDescriptionOnMapin the Vuex store
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/mapviewer/src/utils/kmlUtils.js | Convert showDescriptionOnMap from string to boolean |
| packages/mapviewer/src/store/modules/features.store.js | Allow changeFeatureDescription to take and apply the new flag |
Comments suppressed due to low confidence (1)
packages/mapviewer/src/store/modules/features.store.js:733
- Add or update unit tests to cover the new
showDescriptionOnMapbehavior in this mutation to prevent regressions.
changeFeatureDescription(state, { feature, description, showDescriptionOnMap }) {
144e264 to
3683a3d
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-pb-1828-description-always-displayed
|
| Run status |
|
| Run duration | 05m 46s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
254
|
| View all changes introduced in this branch ↗︎ | |
pakb
approved these changes
Jul 10, 2025
| const showDescriptionOnMap = kmlFeature.get('showDescriptionOnMap') ?? false | ||
| // Convert string to boolean - KML properties are parsed as strings | ||
| const showDescriptionOnMapValue = kmlFeature.get('showDescriptionOnMap') | ||
| const showDescriptionOnMap = showDescriptionOnMapValue === 'true' || showDescriptionOnMapValue === true |
Contributor
There was a problem hiding this comment.
Might be easier to read, I let you choose 😉
Suggested change
| const showDescriptionOnMap = showDescriptionOnMapValue === 'true' || showDescriptionOnMapValue === true | |
| const showDescriptionOnMap = String(showDescriptionOnMapValue).toLowerCase() === 'true' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link