PB-1784: Use eye for KML description visibility and add tooltip for other buttons#1377
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-pb-1784-kml-toggle-visibility
|
| Run status |
|
| Run duration | 05m 32s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
254
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the KML description toggle and adds tooltips to various styling buttons, along with the necessary icon and translation updates.
- Registers new FontAwesome icons (eye/eye-slash, chevrons, etc.)
- Wraps feature-style controls with
GeoadminTooltipand updates the description toggle UI - Adds new i18n keys for line, polygon, marker, and text style tooltips
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| setup-fontawesome.js | Added and reordered icons in the library |
| FeatureStyleEdit.vue | Imported GeoadminTooltip, replaced switch with icon button, wrapped controls in tooltips, and renamed a computed prop |
| rm.json, it.json, fr.json, en.json, de.json (i18n) | Added translation keys for new style tooltips |
Comments suppressed due to low confidence (2)
packages/mapviewer/src/modules/infobox/components/styling/FeatureStyleEdit.vue:143
- [nitpick] The name
isLineis a bit generic. Consider renaming toisGeometryLineorisLineStringfor clarity.
const isLine = computed(() => feature.geometry.type === 'LineString')
packages/mapviewer/src/modules/infobox/components/styling/FeatureStyleEdit.vue:264
- [nitpick] Since you've introduced a new eye/eye-slash toggle button inside a tooltip, consider adding or updating unit/visual regression tests to cover its existence and behavior.
<button
packages/mapviewer/src/modules/infobox/components/styling/FeatureStyleEdit.vue
Show resolved
Hide resolved
packages/mapviewer/src/modules/infobox/components/styling/FeatureStyleEdit.vue
Show resolved
Hide resolved
| {{ t('modify_description') }} | ||
| </label> | ||
| <GeoadminTooltip | ||
| placement="left" |
There was a problem hiding this comment.
I'd set it to placement="top", being placed left covers the "Description" text/title (so default value, no need to set a placement)
It's on purpose, we don't want text on the map for line and/or polygon, so no need to let the user style them. |
b0e2cf6 to
ce9b7db
Compare
Test link
To be discussed:
Test link