PB-1814: Fix download print issue since Service-Worker introduction#1371
Merged
PB-1814: Fix download print issue since Service-Worker introduction#1371
Conversation
Removes the `file-saver` dependency and implements a custom `downloadFile` function to handle file downloads. This change ensures compatibility and addresses potential issues related to browser-specific behavior while Service-Worker is caching our app. Prior to this change, opening the download URL the way it was was leading to a white page where it looked like Service-Worker was trying to inject the app code there (and it failed), no PDF was downloaded
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1814-print-download
|
| Run status |
|
| Run duration | 05m 33s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
254
|
| View all changes introduced in this branch ↗︎ | |
sommerfe
approved these changes
Jul 3, 2025
| } else { | ||
| window.location = documentUrl | ||
| } | ||
| const fileName = `${hostname.value}_${new Date().toISOString()}.pdf`.replaceAll(':', '_') |
Contributor
There was a problem hiding this comment.
this date string is in UTC are we sure we do not want a local timestamp?
Contributor
Author
There was a problem hiding this comment.
AFAIK the usePrint composable is also using a Z in its format, so it was already UTC before.
Might be better to use the current time on the user's machine
Contributor
Author
There was a problem hiding this comment.
I've changed the generateFilename function to use local time, and have used it wherever possible, should be local time in file names now
febb5fe to
d16d031
Compare
d16d031 to
ee27a3d
Compare
|
@pakb Printing of maps is broken with v1.57.1 on Firefox: the downloaded PDF contains some HTML (without body). Chrome works. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
file-saverdependency and implements a customdownloadFilefunction to handle file downloads.This change ensures compatibility and addresses potential issues related to browser-specific behavior while Service-Worker is caching our app. Prior to this change, opening the download URL the way it was was leading to a white page where it looked like Service-Worker was trying to inject the app code there (and it failed), no PDF was downloaded
Test link