Conversation
- Issue : When starting the application with the compare slider active, sometimes the rendering event would not be instantiated, meaning the compare slider would not work. - Reason: When instantiating the compare slider, we used to add a once trigger on precompose if there were no layers ready on the map, but there were layers in the store. precompose is only fired with vector layers (webGL context). This means that, in this case where we had WMS layers which used the canvas context, the event was never fired. - Fix: We use a rendercomplete event instead and ask for a new render.
…nal-layer PB-1685: duplicate COG layers from WMS can't be compared
…vents Mouse events have been removed in favour of pointer events for better compatibility with mobile devices and touch screens.
PB-1054 : Remove mouse events from useMovableElement and replace with pointer events
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 05m 21s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
251
|
| View all changes introduced in this branch ↗︎ | |
schtibe
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing the fix for COG compare, as we are kind of in a situation where it's heavily used (with Blatten and this kind of use case)
Test link