Skip to content

Revert "Showing a banner informing our users about the current outage" - #patch#1321

Merged
pakb merged 1 commit intomasterfrom
remove-outage-banner
May 1, 2025
Merged

Revert "Showing a banner informing our users about the current outage" - #patch#1321
pakb merged 1 commit intomasterfrom
remove-outage-banner

Conversation

@pakb
Copy link
Contributor

@pakb pakb commented May 1, 2025

This reverts commit 5dd6896.

Test link

@github-actions github-actions bot changed the title Revert "Showing a banner informing our users about the current outage" #patch Revert "Showing a banner informing our users about the current outage" - #patch May 1, 2025
@pakb pakb requested a review from schtibe May 1, 2025 14:45
@rebert rebert self-requested a review May 1, 2025 14:48
@schtibe
Copy link
Contributor

schtibe commented May 1, 2025

👍 I guess we'll consider having a permanent functionality that we can more easily enable in the future?
(BTW: I noticed that in the iframes the notice doesn't appear. Don't know if that's good or not, just wanted to mention it for consideration if we create a proper one)

@rebert rebert requested review from rebert and removed request for rebert May 1, 2025 14:48
@pakb pakb merged commit e231077 into master May 1, 2025
6 checks passed
@pakb pakb deleted the remove-outage-banner branch May 1, 2025 14:56
@cypress
Copy link

cypress bot commented May 1, 2025

web-mapviewer    Run #5185

Run Properties:  status check passed Passed #5185  •  git commit e231077e9f: Merge pull request #1321 from geoadmin/remove-outage-banner
Project web-mapviewer
Branch Review master
Run status status check passed Passed #5185
Run duration 01m 30s
Commit git commit e231077e9f: Merge pull request #1321 from geoadmin/remove-outage-banner
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants