Merged
Conversation
The new confederation logo was using some CSS properties that aren't well supported by Safari, and the Swiss flag was stretching way over the logo because of that. When users were clicking on the menu elements, they were in fact clicking on the flag (invisible container) and thus being thrown back to the "home" view.
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 38s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
schtibe
approved these changes
Mar 20, 2025
Contributor
schtibe
left a comment
There was a problem hiding this comment.
LGTM and works on my android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new confederation logo was using some CSS properties that aren't well supported by Safari, and the Swiss flag was stretching way past the logo because of that. When users were clicking on the menu elements, they were in fact clicking on the flag (invisible container) and thus being thrown back to the "home" view.
Test link