Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 41s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
c514b7d to
aab1c4b
Compare
bdbc82e to
7c9619a
Compare
pakb
approved these changes
Mar 12, 2025
Comment on lines
+56
to
+68
| nextTick(() => { | ||
| // Get all children with draggable="false" and remove them | ||
| const nonDraggableChildren = | ||
| activeLayersList.value.querySelectorAll('[draggable="false"]') | ||
| if (nonDraggableChildren.length > 0) { | ||
| nonDraggableChildren.forEach((child) => child.remove()) | ||
| log.debug('Non-draggable children removed:', nonDraggableChildren) | ||
| } else { | ||
| log.debug('No non-draggable children found') | ||
| } | ||
| onMoveLayer(reverseIndex(oldIndex), reverseIndex(newIndex)) | ||
| }) |
Contributor
There was a problem hiding this comment.
works ok. nice find!
can you add a little comment to explain why we are doing this search and destroy on draggable=false?
Just make it clear that is is to fix this bug so we don't remove it in the future because we don't understand why 😉
7c9619a to
4c9890e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link