PB-64, PB-970: Add full support of KMZ file and fixed KML inlined icons #minor#1063
Merged
PB-64, PB-970: Add full support of KMZ file and fixed KML inlined icons #minor#1063
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-970-kmz-support
|
| Run status |
|
| Run duration | 04m 38s |
| Commit |
|
| Committer | Brice Schaffner |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
e9210cd to
ed15b91
Compare
77160f4 to
014b8b8
Compare
pakb
approved these changes
Sep 12, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
All good code wise.
Only thing I was wondering is : should we start documenting which exception will be raised/thrown by our file loading utils? There starts to be a lot of different reasons the handleFileContent or other similar functions could fail by raising errors.
Only support the kml file inside the KMZ.
Icons in kml can be inlined in href using base64 like this <IconStyle><Icon><href>data:image/png;base64,...</href></Icon></IconStyle> So such href cannot be passed to our proxy. Also to get the KML name and/or extent there is no need to proxify the icon urls, because icons won't be loaded during these methods.
014b8b8 to
cbe20af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only support the kml file inside the KMZ.
Test link with icon requiring proxy
Test link with inlined icon in KML as data:
Test link with KMZ with icons
Test link with KMZ used by user (taken from service-proxy logs)
Test link