Skip to content

Update from Master#1062

Merged
ltshb merged 3 commits intodevelopfrom
master
Sep 11, 2024
Merged

Update from Master#1062
ltshb merged 3 commits intodevelopfrom
master

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented Sep 11, 2024

pakb and others added 3 commits September 2, 2024 15:15
New Release v1.46.0 - #minor
…support CORS

GPX file used always the service-proxy even if the server supported CORS. Also
on the service-proxy we could see that some requests were made over service-proxy
for internal server like public.geo.admin.ch. This was due to the fact that if
for any reason the initial request failed (network failure) we fallback to the
service proxy. Now in that case we don't fallback anymore.

NOTE unfortunately there is no way for a web application to check for CORS support
see https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors
PB-977: Don't use service-proxy for internal domain and for GPX that support CORS - #patch
@ltshb ltshb requested a review from pakb September 11, 2024 07:54
@cypress
Copy link

cypress bot commented Sep 11, 2024

web-mapviewer    Run #3280

Run Properties:  status check passed Passed #3280  •  git commit 87535b9de9: Merge pull request #1061 from geoadmin/bug-PB-977-proxy
Project web-mapviewer
Branch Review master
Run status status check passed Passed #3280
Run duration 04m 16s
Commit git commit 87535b9de9: Merge pull request #1061 from geoadmin/bug-PB-977-proxy
Committer Brice Schaffner
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎

@ltshb ltshb merged commit 5ad5753 into develop Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants