PB-859: Use the same approach to compute polygon area.#1053
Merged
ismailsunni merged 4 commits intodevelopfrom Sep 4, 2024
Merged
PB-859: Use the same approach to compute polygon area.#1053ismailsunni merged 4 commits intodevelopfrom
ismailsunni merged 4 commits intodevelopfrom
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
pb-869-different-area-calculation
|
| Run status |
|
| Run duration | 05m 38s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
1f2a4f3 to
7192ce1
Compare
ltshb
approved these changes
Sep 3, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Code looks good but the PR and code should be better documented, eg. why using the GeographicLib ? From where come this library etc...
Contributor
Author
|
@ltshb I don't know either why or when we decide to use GeographicLib in the first time. In this PR I just simply make the area calculated the same way. |
a16abf4 to
fc99fbd
Compare
Contributor
Author
|
@pakb I did put a reference, but I think it's better to use the same code like you said. I have refactored it. |
pakb
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link