PB 898 Fix rumantsch footer link to geo.admin.ch - #patch#1045
Merged
PB 898 Fix rumantsch footer link to geo.admin.ch - #patch#1045
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
bug-pb-898-fix-rumantsch-footer-link
|
| Run status |
|
| Run duration | 04m 11s |
| Commit |
|
| Committer | Stefan Heinemann |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
pakb
reviewed
Aug 29, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
I'm wondering if we shouldn't move that link into our translation file instead of managing i18n stuff for specific language here
Contributor
Author
|
I had the same thought. Then again I wondered if this is ever going to change, and if not, if it's spamming the translation file. I don't know, I'm fine either way, and I trust your experience! |
There's no RM version of the page, so we fall back to DE for that link
26c706c to
ec4fa33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no RM version of the page, so we fall back to DE for that link
Test link
Test link