PB-843 : use LV03 to LV95 reframe services#1044
Merged
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-843-lv03-reframe
|
| Run status |
|
| Run duration | 05m 31s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
ltshb
reviewed
Aug 29, 2024
894b7bb to
9cc2bb4
Compare
ltshb
reviewed
Sep 2, 2024
9cc2bb4 to
39b4a58
Compare
ltshb
reviewed
Sep 2, 2024
instead of using a "simple" matrix reprojection, which leads to a lack of accuracy the further we are from Bern (because LV03 to LV95 isn't a linear change)
rework of how coordinate are extracted from a string, so that it is now an async function (using the reframe service whenever LV03 coordinates are encountered) The coordinate parser now returns parsed coordinates without reprojection, with the coordinate system it was detected in alongside it.
but only return unreframed LV03 coordinate, and let the search store do the reframing after detecting it is LV03 coordinates. Should simplify the code of the extractor, removing the need for async there
should make the code much simpler to use in the context of the search bar
39b4a58 to
c2f1e7e
Compare
ltkum
approved these changes
Sep 9, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
Regarding the src/api/lv03Reframe.api.js file, since the function inside is now able to both reframe from Lv95 to Lv03, and the other way around, perhaps renaming the file to reflect that (maybe something like swissProjectionsReframe.api.js) could be a good idea.
Otherwise, this looks good to me, and I don't want this suggestion to stop you from merging anything.
ltshb
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of reprojecting through proj4, which led to poor precision
Test link with legacy E and N param
Same link on PROD
The difference is about a meter, no more. But for some users, that was a big deal
Test link