PB 773 clickable droplet search - #minor#1031
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
pb-773-clickable-droplet-search
|
| Run status |
|
| Run duration | 04m 34s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
ltshb
left a comment
There was a problem hiding this comment.
We need to differentiate 2 different use case here:
- Search result is a place (coordinate or address)
- Search result is an object (enable the
RBD: building statuslayer and type something likebern)
In the first use case I would reuse the location popup as the user might be interested at any coordinate or might be want to share his address/place to someone using for example whatsapp.
In the second use case I see that we already have a different behavior from the old viewer, where on the old viewer it selected the object and showed its content, it did not add a droplet. In that case we should have the same behavior as on the old viewer simply select the object (similar as if the user clicked the object).
Moreover this PR is breaking the infobox behavior to toggle between infobox and popup.
|
So, in short: Regarding the toggle behaviour, there is a ticket to remove the behaviour, and use can show both location popup and infobox (PB-859). |
e81a553 to
4bab433
Compare
|
hi @ltshb I will implement the second use case in another PR, since the original issue is clicking on the droplet. Thanks |
New screenshot:
Test link