PB-788 : Mobile/tablet help menu section#1028
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-788-help-menu-section
|
| Run status |
|
| Run duration | 04m 51s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
4bfbada to
de61bf3
Compare
de61bf3 to
9dd69d4
Compare
9dd69d4 to
633b3bc
Compare
There was a problem hiding this comment.
Did we not discussed to put the version information in a new window called About ? If I remember well we talk to rename the configuration to help as you did, but then in the help section to add a button About which would open a window with the application informations like version, copyright, condition and terms, link to geo.admin.ch etc.
Otherwise the current help view is not very nice, buttons are way too big and some are not recognize as buttons
In the help section I would only keep the following buttons
- Give feedback (only shown on test.map.geo.admin.ch)
- Report a problem
- Help
- About
About open a new modal window with the following informations:
- app version
- copyright
- link to geo.admin.ch
- link to term and condition
- link to more information
|
no we didn't discuss that, but that might be a good idea. |
ltkum
left a comment
There was a problem hiding this comment.
I have not yet made a deep review, but I noticed the tooltips are no longer reactive to language change. If we switch from french to german (for example), the content of the tooltip remains in french.
That's already the case on map.geo.admin.ch and isn't a regression coming from the changes on this PR |
4c791bc to
da7d1b7
Compare
da7d1b7 to
0355da9
Compare
ltshb
left a comment
There was a problem hiding this comment.
Good just some minor remarks
It wasn't handled properly when a child component was declaring the ID itself, the parent MenuTray couldn't access the value of ID.
and add the language button as an extra button of this new section, so that it may be more easily accessed on mobile/touch devices.
select tags are insensitive to `text-align` prop on Safari, very old bug... So using another "technique" to have the text centered removing/refactoring most component that were previously used in both instances but are now distinct flavors
0355da9 to
50b316c
Compare
With lang selector being transformed into an extra button of this new help section
Test link