Skip to content

Added SSL for the local development server - #minor#1023

Merged
ltshb merged 2 commits intomasterfrom
feat-localhost-ssl
Aug 12, 2024
Merged

Added SSL for the local development server - #minor#1023
ltshb merged 2 commits intomasterfrom
feat-localhost-ssl

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented Aug 7, 2024 •
edited by github-actions bot
Loading

This helps to test some features like the geolocation on device mobile
which requires ssl (at least on iphone).

Test link

@ltshb ltshb requested a review from pakb August 7, 2024 08:37
@github-actions github-actions bot changed the title Added SSL for the local development server Added SSL for the local development server - #minor Aug 7, 2024
pakb
pakb approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meaning it will be an auto-signed certificate? Does it still work with the more sensitive browers? (Safari on mobile for instance)

@ltshb
Copy link
Contributor Author

ltshb commented Aug 8, 2024 •
edited
Loading

meaning it will be an auto-signed certificate? Does it still work with the more sensitive browers? (Safari on mobile for instance)

@pakb Yes the only drawback is that you always have to use https and bypass browser protection by saying each times you know what you do. This is usefull to test geolocation on mobile (iphone) as you are not allowed to enable geolocation on http ! But I could let the code in and commented so if we need it we can simply uncomment it ?

@pakb
Copy link
Contributor

pakb commented Aug 8, 2024

meaning it will be an auto-signed certificate? Does it still work with the more sensitive browers? (Safari on mobile for instance)

@pakb Yes the only drawback is that you always have to use https and bypass browser protection by saying each times you know what you do. This is usefull to test geolocation on mobile (iphone) as you are not allowed to enable geolocation on http ! But I could let the code in and commented so if we need it we can simply uncomment it ?

Is the code still served as unsecured in parallel or only HTTPS?
If only HTTPS, I would propose to add a new npm run dev:https or npm run dev:ssl for the use case of GeolocationAPI testing (and other APIs that requires HTTPS)

@ltshb ltshb force-pushed the feat-localhost-ssl branch from c45a08a to 84d6118 Compare August 9, 2024 07:51
@ltshb ltshb requested a review from pakb August 9, 2024 07:51
@cypress
Copy link

cypress bot commented Aug 9, 2024 •
edited
Loading


Test summary

210 • 0 • 21 • 0

Run details
Project web-mapviewer
Status Passed
Commit 0f0f087
Started Aug 12, 2024 4:57 AM
Ended Aug 12, 2024 5:02 AM
Duration 05:02 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

ltshb added 2 commits August 12, 2024 06:53
@ltshb
Added SSL for the local development server
db97e47 
This helps to test some features like the geolocation on device mobile
which requires ssl (at least on iphone).
@ltshb
Made the ssl optional
0f0f087
@ltshb ltshb force-pushed the feat-localhost-ssl branch from 84d6118 to 0f0f087 Compare August 12, 2024 04:53
@ltshb ltshb merged commit 1b7564c into master Aug 12, 2024
@ltshb ltshb deleted the feat-localhost-ssl branch August 12, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pakb pakb Awaiting requested review from pakb

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltshb @pakb