Update libs to latest available version - #patch#1019
Conversation
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
ltshb
left a comment
There was a problem hiding this comment.
It seems that a lot of tests are not happy with these updates
| "@fortawesome/vue-fontawesome": "^3.0.8", | ||
| "@geoblocks/cesium-compass": "^0.5.0", | ||
| "@geoblocks/mapfishprint": "^0.2.14", | ||
| "@geoblocks/mapfishprint": "^0.2.15", |
There was a problem hiding this comment.
I didn't know that there is already version 0.2.15. I was monitoring the github tag here (https://github.com/geoblocks/mapfishprint/tags). But it seems someone have already released a new version in NPM. And it's based on the develop branch. I have already fixed the issue. May I add my fixes to this branch @pakb ?
There was a problem hiding this comment.
Sure, tests are failing on the print, so maybe your fixes are what is needed
compatible with Node18, some libs could be further upgraded but require Node20 OLv10 can't yet be added, we have to wait for @geoblocks/mapfishprint to add v10 as compatible version in their dependency checks
ismailsunni
left a comment
There was a problem hiding this comment.
LGTM, but I also contributed some code, perhaps other can review it also :D
|
Let's say I reviewed what you did, and you reviewed what I did 😄 |
compatible with Node18, some libs could be further upgraded but require Node20
OLv10 can't yet be added, we have to wait for @geoblocks/mapfishprint to add v10 as compatible version in their dependency checks
Test link