Fix usage of active_submission_index.fetch_add#6
Merged
gents83 merged 1 commit intogents83:masterfrom Apr 7, 2023
niklaskorz:atomic-fetch-add
Merged
Fix usage of active_submission_index.fetch_add#6gents83 merged 1 commit intogents83:masterfrom niklaskorz:atomic-fetch-add
gents83 merged 1 commit intogents83:masterfrom
niklaskorz:atomic-fetch-add
Conversation
From https://doc.rust-lang.org/std/sync/atomic/struct.AtomicU64.html#method.fetch_add: > Adds to the current value, returning the previous value.
Owner
|
Very good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://doc.rust-lang.org/std/sync/atomic/struct.AtomicU64.html#method.fetch_add:
Thus, receiving the new active submission index after incrementing it requires adding
1to the return value locally as well.For comparison, the other uses of
fetch_addin wgpu (unrelated to the current changes) treat the atomic as a "next id" variable instead of an "active id", thus not requiring to increment the return value offetch_add:https://github.com/gfx-rs/wgpu/blob/dd64343f942ff519f980a2adc02fa60f3a7b72a3/wgpu/src/backend/web.rs#L29
https://github.com/gfx-rs/wgpu/blob/dd64343f942ff519f980a2adc02fa60f3a7b72a3/wgpu-hal/src/gles/device.rs#L1094