Elivepatch#5608
Conversation
|
Pull Request assignment Areas affected: ebuilds sys-devel/elivepatch-client: @gentoo/proxy-maint (new package) |
gktrk
left a comment
There was a problem hiding this comment.
The server isn't installing any init or confd file?
Also,
/usr/lib64/python3.4/site-packages/resources
/usr/lib64/python3.4/site-packages/resources/AgentInfo.py
/usr/lib64/python3.4/site-packages/resources/__init__.py
/usr/lib64/python3.4/site-packages/resources/__pycache__
/usr/lib64/python3.4/site-packages/resources/__pycache__/AgentInfo.cpython-34.pyc
/usr/lib64/python3.4/site-packages/resources/__pycache__/AgentInfo.cpython-34.pyo
/usr/lib64/python3.4/site-packages/resources/__pycache__/__init__.cpython-34.pyc
/usr/lib64/python3.4/site-packages/resources/__pycache__/__init__.cpython-34.pyo
/usr/lib64/python3.4/site-packages/resources/__pycache__/dispatcher.cpython-34.pyc
/usr/lib64/python3.4/site-packages/resources/__pycache__/dispatcher.cpython-34.pyo
/usr/lib64/python3.4/site-packages/resources/__pycache__/livepatch.cpython-34.pyc
/usr/lib64/python3.4/site-packages/resources/__pycache__/livepatch.cpython-34.pyo
/usr/lib64/python3.4/site-packages/resources/dispatcher.py
/usr/lib64/python3.4/site-packages/resources/livepatch.py
We should install to our own namespace, not directly under resources. Same goes for elivepatch-client.
| SLOT="0" | ||
| KEYWORDS="~amd64 ~x86" | ||
|
|
||
| RDEPEND=" |
There was a problem hiding this comment.
resources/dispatcher.py:11:import werkzeug
There was a problem hiding this comment.
added werkzeug as dependency
| inherit distutils-r1 | ||
|
|
||
| DESCRIPTION="Live patch installer client working with elivepatch-server" | ||
| HOMEPAGE="https://wiki.gentoo.org/wiki/User:Aliceinwire/elivepatch" |
There was a problem hiding this comment.
Update the HOMEPAGE to point to https://wiki.gentoo.org/wiki/Elivepatch
| inherit distutils-r1 | ||
|
|
||
| DESCRIPTION="Live patch building server with RESTFul Api for elivepatch-client" | ||
| HOMEPAGE="https://wiki.gentoo.org/wiki/User:Aliceinwire/elivepatch" |
There was a problem hiding this comment.
|
I think the resources install location need to be fixed by setup.py and not by the ebuild |
|
after latest changes to elivepatch-server |
|
Why is the category |
| dev-python/git-python[${PYTHON_USEDEP}] | ||
| dev-python/requests[${PYTHON_USEDEP}]" | ||
| DEPEND="${RDEPEND} | ||
| dev-python/setuptools[${PYTHON_USEDEP}]" |
There was a problem hiding this comment.
These entries should have a single level indent after DEPEND/RDEPEND
| dev-python/flask[${PYTHON_USEDEP}] | ||
| dev-python/flask-restful[${PYTHON_USEDEP}]" | ||
| DEPEND="${RDEPEND} | ||
| dev-python/setuptools[${PYTHON_USEDEP}]" |
There was a problem hiding this comment.
These entries should have a single level indent after DEPEND/RDEPEND
Package-Manager: Portage-2.3.6, Repoman-2.3.1
Package-Manager: Portage-2.3.6, Repoman-2.3.1
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
|
Merged in 4c4cea7...e6c6041. Congratulations! |
initial version for elivepatch-server and elivepatch-client