app-containers/incus: fix cross-compilation issue#42095
app-containers/incus: fix cross-compilation issue#42095tormath1 wants to merge 1 commit intogentoo:masterfrom
Conversation
Pull Request assignmentSubmitter: @tormath1 app-containers/incus: @juippis, @gentoo/virtualization Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
juippis
left a comment
There was a problem hiding this comment.
I wonder if you could just edit 6.0.4 and 6.12 for now.
6.10 and 6.11 could be cleaned immediately, and 6.0.4 is pending stabilization so 6.0.3 will be out soon.
Will test later today, but wanted to give my initial thoughts before that.
|
|
||
| if tc-is-cross-compiler ; then | ||
| export GOHOSTARCH=$(go-env_goarch "${CBUILD}") | ||
| if [ "${GOARCH}" != "${GOHOSTARCH}" ]; then |
There was a problem hiding this comment.
We prefer double brackets:
https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0101
There was a problem hiding this comment.
Sorry about that. Thanks!
Pull request CI reportReport generated at: 2025-05-15 09:34 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
This has been tested on Flatcar CI with cross-compilation on `amd64` and `arm64`. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Pull request CI reportReport generated at: 2025-05-15 13:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Hi,
This PR has some history. We first proposed this change: https://github.com/gentoo/gentoo/pull/36323/files#diff-588171aa625435ebb07dcc80d1dd2598cf157d22da00e9daf74825e3bc0e47daR156 it was approved but it was causing issue: https://bugs.gentoo.org/930496 so it has been modified to the current version.
The current change is making Flatcar CI fails (with cross-compilation) during the installation phase:
This proposal has been tested on Flatcar CI with cross-compilation on
amd64andarm64.Thanks.
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.