Skip to content

dev-embedded/u-boot-utils: Add a missing dependency#37991

Closed
krnowak wants to merge 1 commit intogentoo:masterfrom
flatcar-hub:krnowak/u-boot-utils-gnutls
Closed

dev-embedded/u-boot-utils: Add a missing dependency#37991
krnowak wants to merge 1 commit intogentoo:masterfrom
flatcar-hub:krnowak/u-boot-utils-gnutls

Conversation

@krnowak
Copy link
Copy Markdown
Contributor

@krnowak krnowak commented Aug 6, 2024

Fixes a build in Flatcar:

x86_64-pc-linux-gnu-gcc -Wp,-MD,tools/.mkeficapsule.d -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -O2 -pipe -std=gnu11 -DCONFIG_FIT_SIGNATURE -DCONFIG_FIT_SIGNATURE_MAX_SIZE=0xffffffff -DCONFIG_FIT_CIPHER -include ./include/compiler.h -idirafterinclude -idirafter./arch/sandbox/include -I./scripts/dtc/libfdt -I./tools -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -D_GNU_SOURCE -I/usr/include/uuid -Wl,-O2 -Wl,--as-needed -o tools/mkeficapsule tools/mkeficapsule.c -lgnutls -luuid

tools/mkeficapsule.c:21:10: fatal error: gnutls/gnutls.h: No such file or directory
    21 | #include <gnutls/gnutls.h>
       |          ^~~~~~~~~~~~~~~~~
compilation terminated.

The build system silently ignores missing gnutls by adding nothing to CFLAGS and adding -lgnutls to LDLIBS.

I'm not sure if I should also add a dependency on sys-apps/util-linux to make sure that pkg-config --cflags uuid also always works, since the package is the profiles/default/linux/packages list.

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@krnowak
dev-embedded/u-boot-utils: Add a missing dependency
48b5ad9 
Fixes a build in Flatcar:

x86_64-pc-linux-gnu-gcc -Wp,-MD,tools/.mkeficapsule.d -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer  -O2 -pipe   -std=gnu11   -DCONFIG_FIT_SIGNATURE -DCONFIG_FIT_SIGNATURE_MAX_SIZE=0xffffffff -DCONFIG_FIT_CIPHER -include ./include/compiler.h -idirafterinclude -idirafter./arch/sandbox/include -I./scripts/dtc/libfdt -I./tools -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -D_GNU_SOURCE  -I/usr/include/uuid  -Wl,-O2 -Wl,--as-needed -o tools/mkeficapsule tools/mkeficapsule.c   -lgnutls -luuid
tools/mkeficapsule.c:21:10: fatal error: gnutls/gnutls.h: No such file or directory
    21 | #include <gnutls/gnutls.h>
       |          ^~~~~~~~~~~~~~~~~
compilation terminated.

The build system silently ignores missing gnutls by adding nothing to
`CFLAGS` and adding `-lgnutls` to `LDLIBS`.

Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
@gentoo-bot
Copy link
Copy Markdown

gentoo-bot commented Aug 6, 2024

Pull Request assignment

Submitter: @krnowak
Areas affected: ebuilds
Packages affected: dev-embedded/u-boot-tools

dev-embedded/u-boot-tools: @gentoo/embedded

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 6, 2024
@krnowak krnowak mentioned this pull request Aug 6, 2024
Merged
2 tasks
@chewi
Copy link
Copy Markdown
Member

chewi commented Aug 6, 2024

mkeficapsule is not being built on my system, but I don't know why.

@chewi
Copy link
Copy Markdown
Member

chewi commented Aug 6, 2024

Ah, Flatcar is missing the patch that Gentoo has to disable it.

@krnowak
Copy link
Copy Markdown
Contributor Author

krnowak commented Aug 6, 2024

I synced the package with Gentoo on Flatcar, so we should have it the same. Unless the patch is elsewhere.

@gentoo-repo-qa-bot
Copy link
Copy Markdown
Collaborator

gentoo-repo-qa-bot commented Aug 6, 2024

Pull request CI report

Report generated at: 2024-08-06 11:00 UTC
Newest commit scanned: 48b5ad9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/417f55e257/output.html

@jsmolic jsmolic self-requested a review August 6, 2024 13:46
@jsmolic jsmolic self-assigned this Aug 6, 2024
@jsmolic
Copy link
Copy Markdown
Member

jsmolic commented Aug 6, 2024

It looks like the last version dropped the patch but didn't resolve the dependency issues. Since we are already building mkeficapsule, it makes sense to install it if folks want to use it, I will add that bit as well.
Couple of other comments: We should revbump as we are changing runtime dependencies of the package. It's a nitpick, but the commit message should be titled dev-embedded/u-boot-tools: ... as that's the official name of the package in the repo ;-)
And yes, util-linux also needs to be added as mkeficapsule links to its library.

I will merge your contribution and do the remaining changes in the following commit. Thanks!

@gentoo-bot gentoo-bot closed this in 8b99ab0 Aug 6, 2024
@krnowak krnowak deleted the krnowak/u-boot-utils-gnutls branch August 6, 2024 15:01
@krnowak
Copy link
Copy Markdown
Contributor Author

krnowak commented Aug 6, 2024

It looks like the last version dropped the patch but didn't resolve the dependency issues. Since we are already building mkeficapsule, it makes sense to install it if folks want to use it, I will add that bit as well. Couple of other comments: We should revbump as we are changing runtime dependencies of the package.

Right, should have done so, sorry about that.

It's a nitpick, but the commit message should be titled dev-embedded/u-boot-tools: ... as that's the official name of the package in the repo ;-)

Gah, that's a mistake I'm quite consistently doing. :) Thanks for fixing this in the commit message.

And yes, util-linux also needs to be added as mkeficapsule links to its library.

I will merge your contribution and do the remaining changes in the following commit. Thanks!

Thanks too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jsmolic jsmolic jsmolic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jsmolic jsmolic

Labels

assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@krnowak @gentoo-bot @chewi @gentoo-repo-qa-bot @jsmolic