Skip to content

app-containers/podman: Fix cross-compilation issues with gpgme#36805

Closed
krnowak wants to merge 1 commit intogentoo:masterfrom
flatcar-hub:krnowak/podman-cross-compilation
Closed

app-containers/podman: Fix cross-compilation issues with gpgme#36805
krnowak wants to merge 1 commit intogentoo:masterfrom
flatcar-hub:krnowak/podman-cross-compilation

Conversation

@krnowak
Copy link
Copy Markdown
Contributor

@krnowak krnowak commented May 24, 2024

Need to tell cgo to use proper pkg-config with the PKG_CONFIG environment variable.

Bug: https://bugs.gentoo.org/930982


Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

Need to tell cgo to use proper pkg-config with the PKG_CONFIG
environment variable.

Bug: https://bugs.gentoo.org/930982
Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
@gentoo-bot
Copy link
Copy Markdown

Pull Request assignment

Submitter: @krnowak
Areas affected: ebuilds
Packages affected: app-containers/podman

app-containers/podman: @zmedico, @rahilarious, @gentoo/proxy-maint

Linked bugs

Bugs linked: 930982


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 24, 2024
@gentoo-repo-qa-bot
Copy link
Copy Markdown
Collaborator

Pull request CI report

Report generated at: 2024-05-24 12:15 UTC
Newest commit scanned: 6f68e8c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/24248d175f/output.html

@krnowak
Copy link
Copy Markdown
Contributor Author

krnowak commented May 24, 2024

Running pkgcheck scan --commits --net seems to be a PITA on non-Gentoo systems, thus I didn't run it. I'll try to get it working eventually.

@Flowdalic
Copy link
Copy Markdown
Member

There shouldn't be a need to conditionally export PKG_CONFIG. Simply export it unconditionally.

Running pkgcheck scan --commits --net seems to be a PITA on non-Gentoo systems, thus I didn't run it.

Could you describe what the issue is?

@krnowak krnowak deleted the krnowak/podman-cross-compilation branch May 27, 2024 05:00
@krnowak
Copy link
Copy Markdown
Contributor Author

krnowak commented May 27, 2024

@Flowdalic:

There shouldn't be a need to conditionally export PKG_CONFIG. Simply export it unconditionally.

Sorry, my changes got merged before I had a chance to update the PR.

Running pkgcheck scan --commits --net seems to be a PITA on non-Gentoo systems, thus I didn't run it.

Could you describe what the issue is?

app-containers/podman$ pkgcheck scan --commits --net
pkgcheck: error: parsing failed: failed to load make.globals

I suppose I need to set up /etc/portage stuff.

@juippis
Copy link
Copy Markdown
Member

juippis commented Jul 3, 2024

Running pkgcheck scan --commits --net seems to be a PITA on non-Gentoo systems, thus I didn't run it. I'll try to get it working eventually.

If it's not too much bother, you could set up a container to do Gentoo development on to ensure you have a fully set up working environment. I'd recomment lxd or incus for this, because they're widely available on other distros and come with pre-compiled Gentoo containers (both openrc and systemd).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants