Skip to content

dev-python/tlsh: fix build for python 3.12 + musl#36321

Closed
laumann wants to merge 1 commit intogentoo:masterfrom
laumann:dev-python/tlsh/927058
Closed

dev-python/tlsh: fix build for python 3.12 + musl#36321
laumann wants to merge 1 commit intogentoo:masterfrom
laumann:dev-python/tlsh/927058

Conversation

@laumann
Copy link
Copy Markdown
Contributor

@laumann laumann commented Apr 19, 2024

@gentoo-bot
Copy link
Copy Markdown

Pull Request assignment

Submitter: @laumann
Areas affected: ebuilds
Packages affected: dev-python/tlsh

dev-python/tlsh: @laumann, @thesamesam

Linked bugs

Bugs linked: 927058

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Apr 19, 2024
@laumann laumann force-pushed the dev-python/tlsh/927058 branch from 6a3cdf4 to 8ef15da Compare April 19, 2024 10:28
@laumann
Copy link
Copy Markdown
Contributor Author

laumann commented Apr 19, 2024

Forgot the signoff, should be fixed now. Thanks to @dwfreed for pointing out to use PyVarObject_HEAD_INIT macro instead of PyObject_HEAD_INIT.

@laumann laumann force-pushed the dev-python/tlsh/927058 branch from 8ef15da to c70e33f Compare April 19, 2024 11:17
@laumann
Copy link
Copy Markdown
Contributor Author

laumann commented Apr 19, 2024

Rebased on master

Closes: https://bugs.gentoo.org/927058
Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
@laumann laumann force-pushed the dev-python/tlsh/927058 branch from c70e33f to f113faa Compare April 19, 2024 12:46
@laumann
Copy link
Copy Markdown
Contributor Author

laumann commented Apr 19, 2024

Updated to use .gh.tar.gz as the suffix for the tarball.

@gentoo-repo-qa-bot
Copy link
Copy Markdown
Collaborator

Pull request CI report

Report generated at: 2024-04-19 13:24 UTC
Newest commit scanned: f113faa
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/68d41364ec/output.html

@@ -0,0 +1,25 @@
Use PyVarObject_HEAD_INIT instead PyObject_HEAD_INIT
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send this upstream and add the link in a followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants