Fix file changes view to show individual files in new folders + UI #482
Conversation
…rove revert handling
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arnestrickmann
left a comment
There was a problem hiding this comment.
lgtm, thanks Musti
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 7
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if (fs.existsSync(absPath)) { | ||
| fs.unlinkSync(absPath); | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Checkout failure causes unintended file deletion
The git cat-file check and git checkout command are in the same try block. If cat-file succeeds (confirming the file exists in HEAD) but checkout fails for any reason (permissions, disk issues, file locked), the error is caught by the catch block which assumes the file doesn't exist in HEAD and deletes it. This could cause data loss of tracked files when the checkout operation fails for reasons unrelated to file existence.
| captureTelemetry('changes_viewed'); | ||
| })(); | ||
| setSelectedPath(change.path); | ||
| setShowDiffModal(true); |
There was a problem hiding this comment.
Bug: Telemetry tracking calls removed during refactoring
The captureTelemetry('changes_viewed') call was removed from the file change click handler, and captureTelemetry('pr_viewed') was removed from the PR button click handler during the tooltip refactoring. These events are still defined in the telemetry type definitions (telemetry.ts) and allowed events list (telemetryIpc.ts), indicating this was unintentional. The PR description doesn't mention removing telemetry tracking.
Fix file changes view to show individual files in new folders and improve revert handling
Fixes #426 #426
What's Fixed
Files in new folders now show up individually
Reverting new files works correctly
Better button visibility and tooltips
What You'll Notice
See here how now files within new folders are being shown and are accessible to view.
Also fixed this error (when you wanted to revert a new (unstaged) files):
Note
Show individual new files (including inside new folders), correctly revert untracked files, and improve the changes panel with tooltips, telemetry, and a commit & push flow.
--untracked-files=allingit statusacrosssrc/main/ipc/gitIpc.ts,src/main/services/GitService.ts, andsrc/main/services/WorktreeService.tsto surface files in new folders.revertFileinsrc/main/services/GitService.tsto delete untracked files and safely revert tracked files fromHEAD.src/renderer/components/FileChangesPanel.tsx:.gitignoreto ignore.checkouts/.Written by Cursor Bugbot for commit 53aa2be. This will update automatically on new commits. Configure here.