perf(selectivity): speed up pre-test checks#1211
Merged
KuznetsovRoman merged 1 commit intomasterfrom Feb 27, 2026
Merged
Conversation
commit: |
13cbd78 to
d9d5c75
Compare
KuznetsovRoman
commented
Feb 27, 2026
| async getTestChangedDeps(testDeps: NormalizedDependencies): Promise<NormalizedDependencies | null> { | ||
| const depFileTypes: Array<keyof NormalizedDependencies> = ["css", "js", "modules"] as const; | ||
| const result: NormalizedDependencies = { css: [], js: [], modules: [] }; | ||
| const fileContents = await this._getHashFileContents(); |
Member
Author
There was a problem hiding this comment.
Awaiting here in order to not create extra promises for every file
| } | ||
| }), | ||
| ); | ||
| for (const filePath of testDeps[depFileType]) { |
Member
Author
There was a problem hiding this comment.
"for of" is faster than "Promise.all(deps.map)" here
| private readonly _selectivityHashesPath: string; | ||
| private readonly _compresion: SelectivityCompressionType; | ||
| private _hashFileContents: Promise<HashFileContents> | null = null; | ||
| private _fileStateCache = new Map<string, boolean>(); |
Member
Author
There was a problem hiding this comment.
"Is file changed" cache
Comment on lines
+84
to
86
| clearCache(): void { | ||
| this._fileStateCache.clear(); | ||
| } |
Member
Author
There was a problem hiding this comment.
After all checks are passed, we can free up this memory before tests are run
sipayRT
approved these changes
Feb 27, 2026
d9d5c75 to
6999fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.