fix(gui, testplane): send required modules to run method#755
Merged
Conversation
commit: |
✅ Component tests succeed
|
✅ E2E tests succeed
|
DudaGod
commented
Feb 24, 2026
|
|
||
| async run(testCollectionAdapter: TestplaneTestCollectionAdapter, tests: TestSpec[] = [], cliTool: CommanderStatic): Promise<boolean> { | ||
| const {grep, tag, set: sets, browser: browsers, devtools = false, local = false} = cliTool; | ||
| const {grep, tag, set: sets, browser: browsers, devtools = false, local = false, require: requireModules = []} = cliTool; |
Member
Author
There was a problem hiding this comment.
Option require is already supported in testplane - https://github.com/gemini-testing/testplane/blob/master/src/cli/index.ts#L54 and called before emit cli event.
So this option works correctly in master process, but gui run testplane from api and should send requireModules (code below) in order to correctly require modules in workers, here - https://github.com/gemini-testing/testplane/blob/master/src/worker/testplane-facade.ts#L66-L70
e90ed97 to
5b657c4
Compare
sipayRT
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.