Refine API for interned labels#1
Merged
geieredgar merged 9 commits intogeieredgar:interned-labelsfrom Jul 28, 2023
Merged
Conversation
geieredgar
approved these changes
Jul 28, 2023
Owner
geieredgar
left a comment
There was a problem hiding this comment.
I think those are great ergonomics improvements and simplifications for the small cost of making Interner::intern slightly less flexible, so I will go ahead and merge this.
|
|
||
| use std::{ | ||
| borrow::{Borrow, Cow}, | ||
| borrow::Borrow, |
Owner
There was a problem hiding this comment.
With Interner::intern taking a reference, we don't need to use Borrow anymore, since it is a no-op on references. I will push a commit fixing that after merging this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaktrait, and mergedStaticRefinto it..intern()method to the label traits, which makes interning them more ergonomic. This removes the syntaxInternedLabel::from(&label as &dyn Label).