Issue #398: Fix gcc 14 build failure for reversed calloc args#399
Merged
esabol merged 2 commits intogearman:masterfrom Jul 17, 2024
Merged
Conversation
Member
Author
|
@SpamapS : This involves changes to the code (granted only testing code), so I'd like your review when you have time, Clint. Thanks! |
SpamapS
approved these changes
Jul 17, 2024
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request addresses issue #398.
It fixes the reversed
calloc()arguments in the internals tests that was revealed by building with gcc 14.1 on Ubuntu 24.04.It also adds a build using gcc-14 on Ubuntu 24.04 to the GitHub Actions CI workflow.