Adjust linking order of libmemcached{,util}#365
Merged
esabol merged 1 commit intogearman:masterfrom Jun 18, 2023
Merged
Conversation
libmemcachedutil depends on libmemcached, and as such it should be specified first in the command-line when linking. Not doing so can result in build failures in certain scenarios. Ref.: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031450 Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
esabol
approved these changes
Feb 24, 2023
Member
esabol
left a comment
There was a problem hiding this comment.
Kind of surprising that we haven't seen this until now. Change is minor and makes sense. All CI tests pass. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libmemcachedutildepends onlibmemcached, and as such it should bespecified first in the command-line when linking. Not doing so can
result in build failures in certain scenarios.
Ref.: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031450