Issue #346: Remove reliance on gearman.info website from tests#348
Merged
SpamapS merged 1 commit intogearman:masterfrom Nov 13, 2022
Merged
Conversation
Merged
SpamapS
approved these changes
Nov 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"make test" and the GitHub CI workflow currently fail because the
gearman.infowebsite no longer exists. This merge request replaces the tests using the gearman.info domain with google.com. This addresses issue #346.Is it OK to use google.com? I thought so, but if you have a better replacement....
There's still one test that references
exist.gearman.info, but it's skipped. I didn't change that one. Let me know if I should. Or maybe just remove this skipped test entirely?Tag @SpamapS