Conversation
This has never been correct, and has only ever shown 1 if there are any in a priority, or 0 if there are not. That is because the next struct field that as used is confusingly not maintained in this context. Closes #337
Member
|
Thanks, @SpamapS ! Looks good. Simple enough fix. Do you have time to add a test for this? If not, I'm cool with just merging it. P.S. Can you remove Travis CI from the required checks? It's just impeding things at this point. |
Member
Author
|
I tried to add some tests and got frustrated with C/C++ in general but I'll
take another swing at it tonight. And yeah I'll look at the Travis
situation too.
…On Wed, Jun 1, 2022, 3:20 PM Ed Sabol ***@***.***> wrote:
Thanks, @SpamapS <https://github.com/SpamapS> ! Looks good. Simple enough
fix. Do you have time to add a test for this? If not, I'm cool with just
merging it.
P.S. Can you remove Travis CI from the required checks? It's just impeding
things at this point.
—
Reply to this email directly, view it on GitHub
<#338 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADS6YEICNVK2J7WC32BULTVM7O2NANCNFSM5XPRU55Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
esabol
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has never been correct, and has only ever shown 1 if there are any
in a priority, or 0 if there are not. That is because the next
struct field that as used is confusingly not maintained in this context.
Closes #337