Fix Postgres queue table creation on startup#332
Merged
SpamapS merged 2 commits intogearman:masterfrom Jun 2, 2022
Merged
Conversation
when table name contains schema name like `foo.bar`, gearman can't find it in database because it uses query `SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = ...` and `TABLE_NAME` column data contains only `bar` part so each time on startup it tries to recreate it and on second start it fails `PQexec:ERROR: relation "bar" already exists` this is a quick fix, correct fix is to add non-default schema support but this way it will work at least
Member
|
I don't have a problem with this change, but it probably should be noted somewhere that |
Contributor
Author
@esabol sorry, do you mean to mention it in readme or what ? yes, 9.1 was released on 2011-09-12, more than 10 years ago |
Member
I don't know. I probably would've put it in a comment in the code. Maybe it just being mentioned in this issue is sufficient. |
Contributor
Author
|
@esabol added comment in the code and note in summary |
esabol
approved these changes
Dec 24, 2021
esabol
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when table name contains schema name like
foo.bar, gearman can't find it in database because it uses querySELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = ...andTABLE_NAMEcolumn data contains onlybarpart so each time on startup it tries to recreate it and on second start it failsPQexec:ERROR: relation "bar" already existsthis is a quick fix, correct fix is to add non-default schema support but this way it will work at least
COMPATIBILITY NOTE:
IF NOT EXISTSadded in Postgres 9.1