Skip to content

Create a new GitHub Action#329

Merged
SpamapS merged 8 commits intomasterfrom
github-actions
Oct 31, 2021
Merged

Create a new GitHub Action#329
SpamapS merged 8 commits intomasterfrom
github-actions

Conversation

@SpamapS
Copy link
Member

@SpamapS SpamapS commented Oct 28, 2021

Travis seems to be dead so let's try this.

@esabol
Copy link
Member

esabol commented Oct 28, 2021

“make distcheck”? Not sure what the point of that is. We don’t do that in Travis CI.

Travis CI replied to my request for more OSS credits on 2021-10-27, a couple hours before you committed this. They gave the project 25000 OSS credits. It’s not clear to me how many credits one PR build consumes, so I have no idea how long that will last.

@esabol
Copy link
Member

esabol commented Oct 28, 2021

Oh, and it should be “make test”, not “make check”.

@esabol
Copy link
Member

esabol commented Oct 28, 2021

And ./configure should be ./configure --enable-ssl.

An earlier attempt at adding GitHub CI can be found in PR #295 before it was abandoned, in case you want to compare with that.

@SpamapS SpamapS merged commit 06675ba into master Oct 31, 2021
@esabol
Copy link
Member

esabol commented Nov 8, 2021

Did you see my comments here, @SpamapS ?

@esabol esabol deleted the github-actions branch January 4, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants