Issue #279: Fix t/vector test on 32-bit systems#297
Merged
SpamapS merged 1 commit intogearman:masterfrom Aug 27, 2020
Merged
Conversation
p-alik
approved these changes
Aug 7, 2020
SpamapS
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #279 and fixes "make test" on 32-bit systems. Thanks to @cheese for his suggestion on how to do this.
std::numeric_limits<type>is defined in<limits>, but that's not explicitly included bytests/vector.cc. I presume one of the other#includes is pulling it in somehow, since the code compiles and tests cleanly, but maybe we should have an explicit#include <limits>? Let me know what you think.