Add CXXFLAGS=-Wp,-D_GLIBCXX_ASSERTIONS to the gcc-9 build in Travis CI (Redux)#283
Merged
esabol merged 2 commits intogearman:masterfrom Jul 27, 2020
Merged
Conversation
Member
Author
|
Any objection to me merging this? It changes no code. |
p-alik
approved these changes
Jul 16, 2020
p-alik
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still couldn't figure out how to reopen PR #275, so I'm just going to open a new PR.
As discussed in issue #272, this PR ensures C++ STL is used properly, according to
_GLIBCXX_ASSERTIONS. This only adds it to the gcc-9 build. Let me know if you think it should be added to other gcc/g++ builds.Reference:
https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html