Add gcc-9 and clang-9 to Travis CI#265
Merged
p-alik merged 1 commit intogearman:masterfrom Feb 17, 2020
Merged
Conversation
Member
Author
|
Now that PR #267 has been merged, this one can be merged, too. Thanks! |
Member
|
Please rebase on master! |
9f0c3a7 to
c6df765
Compare
p-alik
approved these changes
Feb 11, 2020
Member
Author
Done. |
Member
Author
|
Please restart the job at https://travis-ci.org/gearman/gearmand/jobs/651356089. Turning off concurrent builds in Travis CI doesn't seem to have helped the problem with the tests failing, unfortunately. Should it be turned back on? |
Collaborator
|
I've disabled concurrent job limitation in Travis CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds gcc-9 (on Bionic) and clang-9 to the gearmand Travis CI configuration. The gcc-9 build currently fails with yet another
strncpytruncation warning inlibtest/has.cc. This was one wasn't noticed previously because it requires memcached and libmemcached for that code to be compiled. @zvpunry (or I) will submit a PR soon which fixes this. Once that is merged, the gcc-9 build in this PR will pass. (Tested here: https://travis-ci.org/esabol/gearmand/builds/635884516)