Allow simultaneous passthrough for multiple devices by CameronMParker · Pull Request #23 · gdzx/audiosource

CameronMParker · 2025-05-27T00:25:33Z

This PR would allow Audio Source to forward multiple Android devices to PulseAudio.

Context

Because each invocation of audiosource uses the same socket, device, and pipe names, it is only possible to connect one Android device to PulseAudio. This PR, however, adds both a random UUID to the default device name and allows the user to supply an optional device name. Both of these solutions prevent socket naming collisions and allow you to run multiple audiosource jobs at the same time.

Example

A user could connect a Galaxy device and a Pixel device and select between the two with pactl set-default-source.

$ ./audiosource run -s GALAXY_SERIAL -n galaxy 1> /dev/null &  // running each command in the background
$ ./audiosource run -s PIXEL_SERIAL -n pixel 1> /dev/null &

$ pactl set-default-source galaxy  // if you want to use the galaxy
$ pactl set-default-source pixel  // if you want to use the pixel

A user could also bounce the inputs down into one PulseAudio sink so they could monitor or record from multiple devices at the same time.

$ pactl load-module module-null-sink sink_name=devices
$ pactl load-module module-loopback source=galaxy sink=devices
$ pactl load-module module-loopback source=pixel sink=devices
$ pactl set-default-source devices.monitor

Changes

The default device name is now suffixed by a random UUID.
The variables associated with the pipe, socket, and device have been consolidated.
The install and run commands have been updated to use optional flags instead of positional flags.
The volume command now requires a device name.
Documentation has been updated to reflect the new flag changes as well as highlight multiple device support.

Merge install flag fix

…' into feature-multi-mic

gdzx

Thank you for this PR. That's an interesting use-case. I added a few comments. This will also fix #22.

gdzx · 2025-05-27T16:57:50Z

+		   install [-s SERIAL]        Install Audio Source to Android device (default: debug)
+		   run [-s SERIAL] [-n NAME]  Run Audio Source and start forwarding
+		   volume NAME LEVEL          Set volume to LEVEL (for example, 250%)


The flag should be on the root command instead of being repeated on all the subcommands (like adb [-s serial] <command>. But I think it's better to remove it entirely because it is possible to set it with ANDROID_SERIAL=whatever which is functionally equivalent to passing the -s option to adb, so this is just a matter of documenting that it works and generating a name from it.

gdzx · 2025-05-27T17:03:41Z

-AUDIOSOURCE_NAME=${AUDIOSOURCE_NAME:-android}
-AUDIOSOURCE_PIPE=${AUDIOSOURCE_PIPE:-/tmp/audiosource}
-AUDIOSOURCE_SOCKET=${AUDIOSOURCE_SOCKET:-audiosource}
+AUDIOSOURCE_NAME=${AUDIOSOURCE_NAME:-audiosource$(uuidgen)}


The name should be stable, because if you adjust the volume or other settings in pavucontrol, they would be lost if you launch it again. One way of doing that would be deriving a short identifier from the sha256 sum of the serial (e.g. audiosource-82ab264).

gdzx · 2025-05-27T17:06:09Z

+   $ ./audiosource run -s SERIAL_ONE 1> /dev/null &
+   $ ./audiosource run -s SERIAL_TWO 1> /dev/null &


Suggested change

$ ./audiosource run -s SERIAL_ONE 1> /dev/null &

$ ./audiosource run -s SERIAL_TWO 1> /dev/null &

$ ANDROID_SERIAL=serial1 ./audiosource run 1> /dev/null &

$ ANDROID_SERIAL=serial2 ./audiosource run 1> /dev/null &

gdzx · 2025-05-27T17:15:53Z

@@ -141,33 +150,31 @@ run() {

 	echo '[+] Forwarding audio'


The name of source could be printed here.

CameronMParker · 2025-05-29T02:54:04Z

I've updated the code according to your feedback. Let me know if there are still any changes that need to be made.

- Remove -n option (name can be set with $AUDIOSOURCE_NAME). - Export $ANDROID_SERIAL and remove adb $opts. - Add contextual usage errors.

gdzx · 2025-06-01T15:36:34Z

Hi @CameronMParker,

Thank you for your changes. I added a few of my own. Could you check that everything works properly for your use case?

Best regards,

CameronMParker · 2025-06-01T17:45:05Z

Everything works great! I encountered an error while running ./audiosource run with a single device but my previous commit seems to fix the problem.

gdzx · 2025-06-01T17:59:41Z

What was the bug? I cannot reproduce.

gdzx · 2025-06-01T18:02:05Z

 	pactl load-module module-pipe-source source_name="$AUDIOSOURCE_NAME" channels=1 format=s16 rate=44100 file="/tmp/$AUDIOSOURCE_NAME"

-	echo "[+] Waiting for device $ANDROID_SERIAL"
+	echo "[+] Waiting for device $AUDIOSOURCE_NAME"


Should be $ANDROID_SERIAL as it may not be obvious which device you are waiting for based on the source name if for instance you left the serial set in the environment.

CameronMParker · 2025-06-01T18:24:16Z

If you're running the default ./audiosource run command with just one device, you will get an error saying error: device '' not found. Moving the export ANDROID_SERIAL="$serial" line to inside the case statement seems to fix this. However, another error gets thrown once you get to line 123: ./audiosource run: line 123: ANDROID_SERIAL: unbound variable.

gdzx · 2025-06-01T18:35:30Z

Weird, I have a completely different behavior (with adb here but it also works as expected with the script):

$ ANDROID_SERIAL='' adb shell  # no device
adb: no devices/emulators found

$ ANDROID_SERIAL='' adb shell  # single device
android:/ $

$ ANDROID_SERIAL='foo' adb shell
adb: device 'foo' not found

Can you send me the output of adb version?

CameronMParker · 2025-06-01T18:46:53Z

$ adb version
Android Debug Bridge version 1.0.41
Version 35.0.2-android-tools
Installed as /usr/bin/adb
Running on Linux 6.14.9-arch1-1 (x86_64)

gdzx · 2025-06-01T18:47:03Z


 	shift $((OPTIND-1))

-	export ANDROID_SERIAL="$serial"


Export conditionally like this?

ANDROID_SERIAL="$serial" # Empty ANDROID_SERIAL seems to cause the following issue with ADB: `error: device '' not found`. [ -n "$ANDROID_SERIAL" ] && export ANDROID_SERIAL

gdzx · 2025-06-01T18:53:02Z

$ adb version
Android Debug Bridge version 1.0.41
Version 35.0.2-android-tools
Installed as /usr/bin/adb
Running on Linux 6.14.9-arch1-1 (x86_64)

Same as you except the kernel version 🤷

CameronMParker · 2025-06-01T19:02:03Z

Moving the initial declaration of $ANDROID_SERIAL to file scope seems to fix the issue.

gdzx · 2025-06-01T19:42:42Z

I changed to export ANDROID_SERIAL if it is not empty (with a comment because this is likely to be forgotten). If that works for you, I will merge.

CameronMParker · 2025-06-01T20:18:03Z

Everything seems to be fine now.

CameronMParker and others added 15 commits May 4, 2025 19:31

Append UUID to device, pipe, and socket names

1c98d6f

Replace hard-coded name with argument

b59756a

Change default device name

1ee1174

Take device name as optional argument

4f8c632

Make serial number an optional argument

93e1fdb

Merge branch 'bug-install' into feature-multi-mic

9b4c93e

Merge install flag fix

Update help string with proper arguments

86f9628

Update available environment variables in help string

a7f8805

Update VOL parameter to match README.md

7e6eafd

Update README.md to acknowledge multiple device support

54dbfd3

Merge branch 'gdzx:master' into feature-multi-mic

d8af28e

Merge remote-tracking branch 'upstream' into feature-multi-mic

84f6466

Demonstrate how to connect multiple devices

b286fee

Merge remote-tracking branch 'refs/remotes/upstream/feature-multi-mic…

91bb5d0

…' into feature-multi-mic

Make default device name easier to read in README.md

36ebd47

gdzx reviewed May 27, 2025

View reviewed changes

CameronMParker added 5 commits May 27, 2025 17:21

Log what source is being forwarded to

69f7588

Remove redirect in README.md example

0b9ddf2

Ensure default source name is static

77a96b1

Update default PulseAudio source name

619862a

Update documentation to mention the SERIAL global arg

f96b2b7

CameronMParker and others added 2 commits May 29, 2025 12:34

Update usage section of README.md

e018f24

Refactor PR changes

bb95536

- Remove -n option (name can be set with $AUDIOSOURCE_NAME). - Export $ANDROID_SERIAL and remove adb $opts. - Add contextual usage errors.

Fix empty serial bug

3aafe29

gdzx reviewed Jun 1, 2025

View reviewed changes

Make global to script

4a1694a

Export ANDROID_SERIAL if not empty

bf53149

gdzx merged commit 002982c into gdzx:master Jun 1, 2025

CameronMParker deleted the feature-multi-mic branch June 1, 2025 21:02

		$ ./audiosource run -s SERIAL_ONE 1> /dev/null &
		$ ./audiosource run -s SERIAL_TWO 1> /dev/null &

Conversation

CameronMParker commented May 27, 2025

Context

Example

Changes

Uh oh!

gdzx left a comment

Choose a reason for hiding this comment

Uh oh!

gdzx May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdzx May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdzx May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdzx May 27, 2025

Choose a reason for hiding this comment

Uh oh!

CameronMParker commented May 29, 2025

Uh oh!

gdzx commented Jun 1, 2025

Uh oh!

CameronMParker commented Jun 1, 2025

Uh oh!

gdzx commented Jun 1, 2025

Uh oh!

gdzx Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

CameronMParker commented Jun 1, 2025

Uh oh!

gdzx commented Jun 1, 2025

Uh oh!

CameronMParker commented Jun 1, 2025

Uh oh!

gdzx Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdzx commented Jun 1, 2025

Uh oh!

CameronMParker commented Jun 1, 2025

Uh oh!

gdzx commented Jun 1, 2025

Uh oh!

CameronMParker commented Jun 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gdzx May 27, 2025 •

edited

Loading

gdzx May 27, 2025 •

edited

Loading

gdzx May 27, 2025 •

edited

Loading

gdzx Jun 1, 2025 •

edited

Loading