Skip to content

Add "Parse CSR"#381

Closed
arnydo wants to merge 3 commits intogchq:masterfrom
arnydo:add_parse_csr
Closed

Add "Parse CSR"#381
arnydo wants to merge 3 commits intogchq:masterfrom
arnydo:add_parse_csr

Conversation

@arnydo
Copy link
Copy Markdown
Contributor

@arnydo arnydo commented Oct 10, 2018

Operation to parse Certificate Signing Requests for basic information:

  • CommonName
  • Locality
  • State
  • Country
  • EmailAddress
  • Subject Alternative Names

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 10, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

arnydo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

d98762625
d98762625 suggested changes Oct 12, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@d98762625 d98762625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @arnydo . Could you add some test cases to cover this operation?

src/core/operations/ParseCSR.mjs Outdated
Country: ${csr.subject.getField("C").value}
EmailAddress: ${csr.subject.getField("E").value}
Subject Alternative Names: ${subjectAltNames.map(function (name) {
return name;
Copy link
Copy Markdown
Member

@d98762625 d98762625 Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this map return benefit from some formatting? Rather than having all subjectAltNames being listed with no separator.

@n1474335
Copy link
Copy Markdown
Member

n1474335 commented Nov 7, 2018

Hi @arnydo, this looks great but I'm having trouble getting any example CSRs to parse correctly. Could you take a look and include some tests please?

@arnydo
Copy link
Copy Markdown
Contributor Author

arnydo commented Nov 12, 2018

Ah! It looks like it is expecting specific extensions to be present (subjectAltNames, etc). Ill work on adding some conditions...

@n1474335
Copy link
Copy Markdown
Member

n1474335 commented Sep 4, 2019

Hi @arnydo, are you still intending on working on this?

@arnydo
Copy link
Copy Markdown
Contributor Author

arnydo commented Oct 3, 2019

Hi @n1474335 I haven't had a chance to dig into this and if others don't seem to have a need for it then we can drop it.

@jkataja jkataja mentioned this pull request Jan 22, 2023
Merged
@n1474335
Copy link
Copy Markdown
Member

n1474335 commented Mar 24, 2023

Closed as stale

@n1474335 n1474335 closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@d98762625 d98762625 d98762625 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arnydo @CLAassistant @n1474335 @d98762625