Add "Play Audio" Operation#357
Closed
GCHQ77703 wants to merge 2 commits intogchq:masterfrom
GCHQ77703:audio
Closed
Add "Play Audio" Operation#357GCHQ77703 wants to merge 2 commits intogchq:masterfrom GCHQ77703:audio
GCHQ77703 wants to merge 2 commits intogchq:masterfrom
GCHQ77703:audio
Conversation
Member
|
Rather than requiring a data URI as input, would it be possible to just accept a |
Member
|
This has been addressed in #446, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to render a media data URI into a playable audio file. These look something like this. To get this into something that's playable we parse the data URI for it's type and convert the rest into binary data. We then create a blob from this data and from that blob we can create a blob URI which is a valid
srcon an audio element.Creating this from the
Filetype would seem simple following that logic, as it is just an extension to aBlob. Unfortunately, this is not the case because it appearsDish.mjsdoesn't persist the type of a file (nor could I see a way of it doing so, especially due to the MIME type possibly changing through processing).