Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the 'Shellcode' module, currently comprising of one operation: 'Disassemble x86'.
This operation supports 64-, 32-, and 16-bit code written for Intel or AMD x86 processors.
This closes #68. I initially tried to use capstone.js, however its size (5MB minified) caused no end of issues with webpack, so I ended up going with X86-64-Disassembler-JS. In future it would be nice to switch to a more comprehensive library that supports more architectures, but this is a good start while we're waiting for other libraries to mature.