Skip to content

fix: GetAllCasings.mjs - newline bug#1328

Merged
n1474335 merged 2 commits intogchq:masterfrom
pH-T:master
Mar 29, 2022
Merged

fix: GetAllCasings.mjs - newline bug#1328
n1474335 merged 2 commits intogchq:masterfrom
pH-T:master

Conversation

@pH-T
Copy link
Copy Markdown
Contributor

@pH-T pH-T commented Mar 28, 2022

@n1474335 n1474335 merged commit 18022a2 into gchq:master Mar 29, 2022
@wesinator
Copy link
Copy Markdown
Contributor

Hi, two issues I'e noticed with this implementation:

  • name - calling it "casing" while the others are case make it harder to find - suggest renaming to "get all cases"?
  • there seems to be a bug in the iteration if the input string has commas, such as:
this is a test, test one, test two
this is a test, test one

The use case for this is getting the "normal" proper noun case on a separated list of names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants